-
Notifications
You must be signed in to change notification settings - Fork 181
Feature/improve pii extproc testing #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rootfs
merged 2 commits into
vllm-project:main
from
yossiovadia:feature/improve-pii-extproc-testing
Oct 3, 2025
Merged
Feature/improve pii extproc testing #335
rootfs
merged 2 commits into
vllm-project:main
from
yossiovadia:feature/improve-pii-extproc-testing
Oct 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion 🔍 ENHANCED PII TESTING FRAMEWORK: - Added comprehensive ExtProc PII detection test (TEST 3.5) - Tests differential behavior between PII and safe content - Validates production pipeline PII handling capabilities - Monitors routing decisions, processing times, and blocking behavior 📋 IMPROVED TEST COVERAGE: - Enhanced test case generation with cache-busting timestamps - Added comprehensive PII pattern analysis across multiple entity types - Better detection of ExtProc PII filtering mechanisms - More detailed logging and result analysis ⚙️ SMART PII POLICY CONFIGURATION: - Model-A: Strict PII policy (allow_by_default: false, EMAIL_ADDRESS only) - Model-B: Permissive PII policy (allow_by_default: true, all PII types) - Mixed policy approach enables better testing of PII routing behavior 📊 TEST CAPABILITIES: - Detects PII blocking vs routing-only behavior - Monitors differential model selection based on PII content - Validates security policy enforcement in production pipeline - Comprehensive analysis of ExtProc PII detection indicators This establishes a comprehensive testing framework that will reveal any gaps in PII detection and policy enforcement across the entire semantic router pipeline. Signed-off-by: Yossi Ovadia <[email protected]>
Apply automatic Python code formatting from black to ensure consistent code style across the test file. No functional changes - only formatting improvements including: - Trailing commas for better diffs - Line wrapping for readability - Consistent spacing around operators Signed-off-by: Yossi Ovadia <[email protected]>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
approved these changes
Oct 3, 2025
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
* feat: enhance PII detection testing with comprehensive ExtProc validation 🔍 ENHANCED PII TESTING FRAMEWORK: - Added comprehensive ExtProc PII detection test (TEST 3.5) - Tests differential behavior between PII and safe content - Validates production pipeline PII handling capabilities - Monitors routing decisions, processing times, and blocking behavior 📋 IMPROVED TEST COVERAGE: - Enhanced test case generation with cache-busting timestamps - Added comprehensive PII pattern analysis across multiple entity types - Better detection of ExtProc PII filtering mechanisms - More detailed logging and result analysis ⚙️ SMART PII POLICY CONFIGURATION: - Model-A: Strict PII policy (allow_by_default: false, EMAIL_ADDRESS only) - Model-B: Permissive PII policy (allow_by_default: true, all PII types) - Mixed policy approach enables better testing of PII routing behavior 📊 TEST CAPABILITIES: - Detects PII blocking vs routing-only behavior - Monitors differential model selection based on PII content - Validates security policy enforcement in production pipeline - Comprehensive analysis of ExtProc PII detection indicators This establishes a comprehensive testing framework that will reveal any gaps in PII detection and policy enforcement across the entire semantic router pipeline. Signed-off-by: Yossi Ovadia <[email protected]> * style: apply black formatting to PII detection test Apply automatic Python code formatting from black to ensure consistent code style across the test file. No functional changes - only formatting improvements including: - Trailing commas for better diffs - Line wrapping for readability - Consistent spacing around operators Signed-off-by: Yossi Ovadia <[email protected]> --------- Signed-off-by: Yossi Ovadia <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
* feat: enhance PII detection testing with comprehensive ExtProc validation 🔍 ENHANCED PII TESTING FRAMEWORK: - Added comprehensive ExtProc PII detection test (TEST 3.5) - Tests differential behavior between PII and safe content - Validates production pipeline PII handling capabilities - Monitors routing decisions, processing times, and blocking behavior 📋 IMPROVED TEST COVERAGE: - Enhanced test case generation with cache-busting timestamps - Added comprehensive PII pattern analysis across multiple entity types - Better detection of ExtProc PII filtering mechanisms - More detailed logging and result analysis ⚙️ SMART PII POLICY CONFIGURATION: - Model-A: Strict PII policy (allow_by_default: false, EMAIL_ADDRESS only) - Model-B: Permissive PII policy (allow_by_default: true, all PII types) - Mixed policy approach enables better testing of PII routing behavior 📊 TEST CAPABILITIES: - Detects PII blocking vs routing-only behavior - Monitors differential model selection based on PII content - Validates security policy enforcement in production pipeline - Comprehensive analysis of ExtProc PII detection indicators This establishes a comprehensive testing framework that will reveal any gaps in PII detection and policy enforcement across the entire semantic router pipeline. Signed-off-by: Yossi Ovadia <[email protected]> * style: apply black formatting to PII detection test Apply automatic Python code formatting from black to ensure consistent code style across the test file. No functional changes - only formatting improvements including: - Trailing commas for better diffs - Line wrapping for readability - Consistent spacing around operators Signed-off-by: Yossi Ovadia <[email protected]> --------- Signed-off-by: Yossi Ovadia <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
* feat: enhance PII detection testing with comprehensive ExtProc validation 🔍 ENHANCED PII TESTING FRAMEWORK: - Added comprehensive ExtProc PII detection test (TEST 3.5) - Tests differential behavior between PII and safe content - Validates production pipeline PII handling capabilities - Monitors routing decisions, processing times, and blocking behavior 📋 IMPROVED TEST COVERAGE: - Enhanced test case generation with cache-busting timestamps - Added comprehensive PII pattern analysis across multiple entity types - Better detection of ExtProc PII filtering mechanisms - More detailed logging and result analysis ⚙️ SMART PII POLICY CONFIGURATION: - Model-A: Strict PII policy (allow_by_default: false, EMAIL_ADDRESS only) - Model-B: Permissive PII policy (allow_by_default: true, all PII types) - Mixed policy approach enables better testing of PII routing behavior 📊 TEST CAPABILITIES: - Detects PII blocking vs routing-only behavior - Monitors differential model selection based on PII content - Validates security policy enforcement in production pipeline - Comprehensive analysis of ExtProc PII detection indicators This establishes a comprehensive testing framework that will reveal any gaps in PII detection and policy enforcement across the entire semantic router pipeline. Signed-off-by: Yossi Ovadia <[email protected]> * style: apply black formatting to PII detection test Apply automatic Python code formatting from black to ensure consistent code style across the test file. No functional changes - only formatting improvements including: - Trailing commas for better diffs - Line wrapping for readability - Consistent spacing around operators Signed-off-by: Yossi Ovadia <[email protected]> --------- Signed-off-by: Yossi Ovadia <[email protected]> Signed-off-by: liuhy <[email protected]>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
* feat: enhance PII detection testing with comprehensive ExtProc validation 🔍 ENHANCED PII TESTING FRAMEWORK: - Added comprehensive ExtProc PII detection test (TEST 3.5) - Tests differential behavior between PII and safe content - Validates production pipeline PII handling capabilities - Monitors routing decisions, processing times, and blocking behavior 📋 IMPROVED TEST COVERAGE: - Enhanced test case generation with cache-busting timestamps - Added comprehensive PII pattern analysis across multiple entity types - Better detection of ExtProc PII filtering mechanisms - More detailed logging and result analysis ⚙️ SMART PII POLICY CONFIGURATION: - Model-A: Strict PII policy (allow_by_default: false, EMAIL_ADDRESS only) - Model-B: Permissive PII policy (allow_by_default: true, all PII types) - Mixed policy approach enables better testing of PII routing behavior 📊 TEST CAPABILITIES: - Detects PII blocking vs routing-only behavior - Monitors differential model selection based on PII content - Validates security policy enforcement in production pipeline - Comprehensive analysis of ExtProc PII detection indicators This establishes a comprehensive testing framework that will reveal any gaps in PII detection and policy enforcement across the entire semantic router pipeline. Signed-off-by: Yossi Ovadia <[email protected]> * style: apply black formatting to PII detection test Apply automatic Python code formatting from black to ensure consistent code style across the test file. No functional changes - only formatting improvements including: - Trailing commas for better diffs - Line wrapping for readability - Consistent spacing around operators Signed-off-by: Yossi Ovadia <[email protected]> --------- Signed-off-by: Yossi Ovadia <[email protected]> Signed-off-by: liuhy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PII Detection: ✅ Working perfectly across all pathways
🚫 The Gap We Identified